Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to latest rules_kotlin #303

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Update to latest rules_kotlin #303

wants to merge 7 commits into from

Conversation

sgowroji
Copy link
Member

Fixes #301

@sgowroji sgowroji requested review from ahumesky and jin as code owners August 24, 2023 06:35
@sgowroji sgowroji changed the title update to latest rules_kotlin Update to latest rules_kotlin Aug 24, 2023
@Wyverald
Copy link
Member

looks like the android/jetpack-compose example is using an older Bazel version which doesn't support some of the new syntax. could we just remove https://github.com/bazelbuild/examples/blob/main/android/jetpack-compose/.bazelversion ?

@meteorcloudy
Copy link
Member

@jin Can you help review this one?

@meteorcloudy
Copy link
Member

@sgowroji Can you update android/jetpack-compose/.bazelversion to just last_green?

@sgowroji
Change version to last_green
3df90ab 
Change version to last_green
@meteorcloudy
Copy link
Member

The test is still failing, does rules_kotlin 1.8 actually include the fix?

@sgowroji sgowroji mentioned this pull request Sep 4, 2023
Merged
@sgowroji
Copy link
Member Author

sgowroji commented Sep 7, 2023

Waiting for rules_kotlin release bazelbuild/rules_kotlin#1005 (comment)

sgowroji
sgowroji commented Sep 8, 2023
View reviewed changes
Copy link
Member Author

@sgowroji sgowroji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating to 1.8.1 rules_kotlin

@meteorcloudy
Copy link
Member

@ted-xie Can you take a look at the failure, not sure what's missing.

@ted-xie
Copy link

ted-xie commented Sep 20, 2023

Sorry to pass the buck, but @Bencodes probably knows the most about rules_kotlin, bazel's jetpack-compose support, and their interaction.

@alexeagle
Copy link
Collaborator

Hey @Bencodes I'm just doing a maintenance pass over the repo, is that something you can help with? 🙇🏻

@sgowroji sgowroji mentioned this pull request Jan 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahumesky ahumesky Awaiting requested review from ahumesky ahumesky is a code owner

@jin jin Awaiting requested review from jin jin is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error: 'JavaInfo' value has no field or method 'transitive_deps'
5 participants
@sgowroji @Wyverald @meteorcloudy @ted-xie @alexeagle